feat(vector): support 2560-dimensional embeddings - #298
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: get-convex/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe supported vector dimensions now include 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ianmacartney
left a comment
There was a problem hiding this comment.
thanks! Sounds like it's worth adding
commit: |
|
I'll defer to @robelest whether we should wait to land it or replay the change on top of some big structural PRs he's working with, but |
Summary
Add
2560to the vector dimensions supported by the Agent component.This enables embedding models that return 2560-dimensional vectors, including:
perplexity/pplx-embed-v1-4bperplexity/pplx-embed-context-v1-4bMotivation
The Agent component currently restricts vector dimensions to a predefined
allowlist. Although Convex vector indexes support 2560 dimensions, it is
missing from that list.
As a result, applications cannot use these embedding models at their native
dimension without maintaining a local patch or reducing the embedding size.
Changes
2560toVectorDimensionsTesting
npm run build:cleannpm run testnpm run lintnpm run typecheckI have also been using this change successfully through a local package patch
with
perplexity/pplx-embed-v1-4b.By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.