Add reopen closed tab shortcut - #2686
Open
brsbl wants to merge 10 commits into
Open
Conversation
…tab-shortcut-thr_ufp89hj9ea # Conflicts: # packages/plugin-api-map/sdk-public-api.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The secondary panel had no command or state for restoring a closed tab, and the desktop-only
Cmd+Shift+Tbinding was assigned to opening a terminal instead of the platform-standard reopen gesture. The first implementation also treated incomplete storage inventories as authoritative, rebuilt restored tabs from canonical rather than visible placement, and left browserWebContentsViews visible while the host renderer reloaded.What changed
panel.reopenClosedTabapp command, a desktop default ofCmd+Shift+T, and a matching native File menu item.WebContentsViews before native or keyboard renderer reloads so stale child views cannot cover or intercept the replacement renderer; the fresh renderer reattaches and shows them after startup.Cmd+Shift+Enterbinding and documented the shared panel command for plugin surfaces.HOST_DAEMON_PROTOCOL_VERSIONis unchanged.Before
The merge base has no reopen-closed-tab command.
Native View → Reload with an open browser view could leave the host renderer blank.
After
The exact PR branch exposes the desktop shortcut as
Cmd+Shift+T.Native View → Reload restores both the host renderer and embedded browser view.
Exact-head desktop smoke evidence
Two browser tabs open:
Both browser tabs closed:
First
Cmd+Shift+Trestores the most recently closed tab and its URL:Second
Cmd+Shift+Trestores the remaining tab:A third
Cmd+Shift+Tis a no-op, and the original visible order remainsBrowser · Example Domain:How you verified
e82f32cb5d961299d69be7f2f1bfde80b49a1270in the branch desktop app, Electron 41.7.0.Cmd+Shift+Tgesture twice. The tabs returned in reverse close order, the URL was retained, the original visible placement was restored, and a third press was a no-op.Final review and triage
One deliberate architecture and implementation review was run for this PR. Its findings were validated, then all confirmed product defects from the review and smoke pass were fixed:
No known product defect remains from the review, smoke test, or screenshot inspection. One QA-infrastructure observation remains outside this feature: on a cold desktop-dev launch, the launcher's fixed readiness window can expire while branch packaging is still completing, producing a temporary blank window. Logs and the later automatic load established that this was service readiness timing rather than a renderer crash.
BB-Thread-ID: thr_ufp89hj9ea