feat(plugins): support built-in composer mentions - #2684
Open
smsunarto wants to merge 2 commits into
Open
Conversation
fix(plugins): log unawaited insertMention failures (cubic iteration 4) fix(plugins): reject invalid provider mentions and drop forbidden comments (cubic iteration 3) fix(plugins): guard mention insertion race and unknown kinds (cubic iteration 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The public plugin composer API only accepted provider-owned mentions. Plugins could not insert BB-owned thread, project, section, or path mentions while letting BB resolve canonical labels and selected-environment targets.
What changed
How you verified