Backfill missing project remote after source updates - #2683
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Backfill missing project remote after source updates#2683bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
The source-update route changed the source row but omitted the existing host inspection and guarded project remote update.
The direct reproduction report confirmed this cause at the trusted main commit.
What changed
The server now inspects the exact updated local source when the stored project remote is null.
It uses the existing setter, which cannot replace a non-null remote.
This change does not alter the wire protocol, schema, CLI contract, or stored-data format.
How you verified
project.inspectcommand was queued.pnpm exec turbo run typecheck --filter=@bb/serverpassed.pnpm exec turbo run test --filter=@bb/server --forcepassed 2,071 tests.git diff --checkpassed.The change has 77 text lines: 75 additions and 2 deletions.
Fixes #2682