Skip to content

Conversation

@santiagomoneta
Copy link

  • I made a readme file that is so easy to follow that my kid could do it.
  • Edited the telegraf file to NOT include any personal IP (could add a py script to ask for this info and update the file.. maybe later.)

- I made a readme file that is so easy to follow that my kid could do it.
- Edited the telegraf file to NOT include any personal IP (could add a py script to ask for this info and update the file.. maybe later.)
- Updated the telegraf file to use variables, so no need to updated.
- Addedd more screenshots
- Added Pihole and DNSCrypt-proxy services
- Added Grafana dashboard json to import
- Updated Readme
added warning on the 10/100 LAN limitation of the Raspi3
@germancorbettamulesoft
Copy link

Interesting changes, but the scope of the project is just ISP monitoring and adding the DNS would affect ISP responses.
I think all this changes are quite good for another project which eventually include the DNS functionality.

Taking that into consideration, I have the following changes to recommend and upload it:

  1. Also the "morning-night" could be replace with $HOSTNAME and avoid referring to the name of the device.
  2. You are never pointing to the "download this repo files" before the "balena push"
  3. Finally the environment variables are great, but it's necessary to use the "$" sign before them.

What do you think? Should we create another project with this changes to include the scope change of secure DNS?

@germancorbetta
Copy link
Owner

Could you please create a branch for this so we could review it without affecting master for the time-being? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants