Update thiserror to v2
#112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It seems like thiserror v2 now has a minimum compatible rust version of 1.68, while the gpx crate wants 1.67. So that's a problem I'm afraid? Can we bump to 1.68 as well? Edit: The thiserror change isn't released yet, but I guess it will be released eventually as 2.0.18. Edit 2: So maybe cargo is now smart enough to pick the older (now still current) thiserror 2.0.17 when using Rust 1.67 and this is actually fine even in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to users.I added a changelog entry since the geojson PR had one too, but not sure if it's really that interesting for users. As I understand it, this shouldn't change the public API of the gpx crate.