Skip to content

Conversation

koplas
Copy link

@koplas koplas commented Aug 7, 2025

This occurs when slave nodes harvest the master nodes, while the master node is harvesting. The TaxonomyReader is never closed, which results in high memory consumption.

I could not find any usage in the code where closing the TaxonomyReader would result in any issues.
To verify find all usages of IndexAndTaxonomy (should be 46 locations) and check that the TaxonomyReader is not used after close() was called.

Related #4481

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@jahow
Copy link
Member

jahow commented Aug 27, 2025

Hi @koplas, thank you for your work on this matter. Since your change is not directly security-related and targets a legacy branch that is not maintained any more, it will not be merged nor reviewed. I hope this makes sense to you. thanks

@koplas
Copy link
Author

koplas commented Aug 27, 2025

Thank you for the info! I’m closing this pull request, as new versions don’t have this problem.

@koplas koplas closed this Aug 27, 2025
@bernhardreiter
Copy link
Contributor

Can you keep the pull request open, there are still significant users of the 3 series and it may come into long term maintenance again.

This occurs when slave nodes harvest the master nodes, while the
master node is harvesting. The TaxonomyReader is never closed,
which results in high memory consumption.
I could not find any usage in the code where closing the
TaxonomyReader would result in any issues.
@koplas
Copy link
Author

koplas commented Sep 2, 2025

Reopening pull request on request of @bernhardreiter.

@koplas koplas reopened this Sep 2, 2025
@koplas koplas force-pushed the fix-memory-leak-3.12 branch from aaefbde to eafa51c Compare September 2, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants