PB-1383: layers module #1258
Draft
PB-1383: layers module #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schtibe
force-pushed
the
feat-pb-1383-layers-module
branch
4 times, most recently
from
e4560f0 to
09ef230
Compare
schtibe
force-pushed
the
feat-pb-1383-layers-module
branch
9 times, most recently
from
234bb28 to
6860cdf
Compare
schtibe
force-pushed
the
feat-pb-1383-layers-module
branch
15 times, most recently
from
656f178 to
fd3cc57
Compare
schtibe
force-pushed
the
feat-pb-1383-layers-module
branch
4 times, most recently
from
c215f85 to
61ced2e
Compare
pakb
force-pushed
the
feat-pb-1383-layers-module
branch
from
61ced2e to
817606a
Compare
pakb
force-pushed
the
feat-pb-1383-layers-module
branch
6 times, most recently
from
29d4f16 to
ebc821c
Compare
pakb
force-pushed
the
feat-pb-1383-layers-module
branch
4 times, most recently
from
3631390 to
da2ac11
Compare
pakb
force-pushed
the
feat-pb-1383-layers-module
branch
from
da2ac11 to
88aa27f
Compare
pakb
force-pushed
the
feat-pb-1383-layers-module
branch
from
88aa27f to
debf6d0
Compare
pakb
force-pushed
the
feat-pb-1383-layers-module
branch
from
debf6d0 to
f693119
Compare
- Rework the WMS getCap parsing with TypeScript - Migrates to `unplugin-dts` for declaration generation. - Adding some rules to the TS config to improve intelisense performance while developing - Enforces stricter TypeScript rules with `@typescript-eslint/consistent-type-exports` and `@typescript-eslint/no-import-type-side-effects`. - migrating marker style to TypeScript
pakb
force-pushed
the
feat-pb-1383-layers-module
branch
from
f693119 to
a723d83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the layers in a new module called @geoadmin/layers.
Switching from having classes (which aren't ideal in the store) to simple interfaces that determine the structure of the various layers. Since this takes away the constructors, I added utility functions to construct the layers, so that we don't have to always specify every bit of information.
I also moved the capability parsers of wmts and wms to the new module. Maybe some other parsers could follow too, I don't know that yet. There's some coupling to defaults which are in mapviewer, we need to figure that out first.
The advantage of this change is clearly not very impactful yet. We'll have to switch the Vue components to TS to leverage the interfaces, for instance. I rather think as of now this module is just a step in the right direction. Maybe we'll also refactor the layers structure, I heard ideas about simplifying some stuff, for instance to merge GeoAdminWM(T)S with ExternalWM(T)s. Maybe we could, in the future, organize the layers around traits, like "FileBased", "wmtsBased" etc.
Maybe we now have a starting point to consider what else should be done around the layers of the mapviewer.
Test link