crossdev: refuse to delete the host toolchain#40
Open
Leb02 wants to merge 1 commit intogentoo:masterfrom
Open
Conversation
avoids nuking a whole system by misinputing the name of the toolchain you want to --clean Signed-off-by: Elouan Lesteven <elouan.lesteven@protonmail.com>
thesamesam
reviewed
May 1, 2026
|
|
||
| setup_portage_vars | ||
|
|
||
| if [[ ${HCHOST} == "${CTARGET}" ]] ; then |
Member
There was a problem hiding this comment.
Do we need this? Isn't it redundant with the loop below?
setup_portage_vars does:
# Collect all CHOST* visible for host. We need to make sure
# not to clobber any of native CHOSTs.
HCHOSTS=(${HCHOST})
for abi in $(portageq envvar ABI MULTILIB_ABIS DEFAULT_ABI); do
HCHOSTS+=($(portageq envvar CHOST_${abi}))
doneso HCHOSTS always contains HCHOST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where you could delete your host toolchain using the --clean option