feat: consensus add config for appeal rounds#869
Closed
kstroobants wants to merge 5 commits intomainfrom
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
==========================================
- Coverage 16.84% 16.77% -0.08%
==========================================
Files 127 128 +1
Lines 10098 10141 +43
Branches 253 254 +1
==========================================
Hits 1701 1701
- Misses 8312 8354 +42
- Partials 85 86 +1 ☔ View full report in Codecov by Sentry. |
cristiam86
requested changes
Feb 20, 2025
|
Contributor
Author
|
Raise a JSONRPCError when you appeal a transaction above the appeal limit. -> it cannot be appealed anymore so immediately finalize the transaction. |
Contributor
Author
|
Solved with #1268 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #828
What
Todo
Set the frontend value to the config_appeal_rounds of the transaction in the backend database (same as LeaderOnly and transactions_processor.insert_transaction()).
Why
Testing done
Decisions made
NA.
Checks
Reviewing tips
User facing release notes
Max appeal rounds can be set for each transaction.