Skip to content

fix: correct typos across codebase (variable names, comments, docs)#1277

Merged
cristiam86 merged 8 commits intogenlayerlabs:mainfrom
NikolaiKryshnev:fix
Feb 24, 2026
Merged

fix: correct typos across codebase (variable names, comments, docs)#1277
cristiam86 merged 8 commits intogenlayerlabs:mainfrom
NikolaiKryshnev:fix

Conversation

@NikolaiKryshnev
Copy link
Contributor

@NikolaiKryshnev NikolaiKryshnev commented Jul 30, 2025

What

  • Fixed multiple typos across different files:

    • destionationdestination
    • becasebecause
    • assingassign
    • disconnnectdisconnect
    • individialindividual
    • stardardstandard

Why

  • To improve code quality and readability
  • Prevent potential runtime issues due to incorrect variable names (e.g., destionation)
  • Make documentation and log output clearer for future maintainers

Testing done

  • Verified builds still run successfully
  • Confirmed typos were purely textual and did not affect application logic
  • Ran affected code paths manually (e.g., ncp, websocket connect/disconnect) to ensure correctness

Decisions made

  • Separated each typo fix into individual commits for traceability and easier reverts if needed
  • Followed conventional commits for commit messages

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

  • All changes are trivial typo fixes; no logic has been modified
  • Each fix is scoped and clearly labeled in the diff and commit history

User facing release notes

No user-facing changes. Internal typo corrections in code, logs, and comments.


Summary by CodeRabbit

  • Bug Fixes
    • Corrected multiple spelling errors in variable names, comments, and documentation across the codebase.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 30, 2025

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fc1abe and edee0e6.

📒 Files selected for processing (1)
  • frontend/scripts/contract-examples.js

📝 Walkthrough

Walkthrough

This pull request addresses spelling and typographical errors across multiple files, including correcting variable naming, comment text, string literals, and markdown documentation. No functional or logical changes were made to the codebase.

Changes

Cohort / File(s) Summary
Script Variable Naming
frontend/scripts/contract-examples.js
Corrected variable name from destionation to destination throughout the script in path resolution, existence checks, and copy operations.
Component Comment Fixes
frontend/src/components/JsonViewer/json-box.vue
Fixed spelling errors in comments: "becase" → "because" in mounted() hook, and "assing" → "assign" in render() method.
Python Test String Literal
tests/integration/icontracts/contracts/intelligent_oracle.py
Corrected typo in evaluate_all_sources function's prompt text: "individial" → "individual".
Documentation Markdown
tests/integration/icontracts/ideas.md
Fixed typographical error in Lottery section description: "stardard ERC20" → "standard ERC20".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

A rabbit hops through lines of code,
Finding typos on the road,
With nimble paws, we fix with care,
Each misspelled word, we repair! 🐰✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
frontend/scripts/contract-examples.js (1)

15-16: Undefined variable destionation breaks copy operation.

ncp is still called with the old misspelled variable, causing a ReferenceError at runtime.

-ncp(source, destionation,
+ncp(source, destination,
🧹 Nitpick comments (3)
frontend/src/hooks/useWebSocketClient.ts (1)

14-16: Consider guarding against duplicate listeners on repeated hook calls.

The typo is fixed – 👍 – but every invocation of useWebSocketClient() still adds new connect/disconnect listeners to the same socket instance, leading to duplicated logs (and any other side-effects you later add).
Either wrap listener registration in an if (!listenersAdded) flag or move it inside the if (!webSocketClient) block.

tests/integration/icontracts/contracts/intelligent_oracle.py (2)

276-282: Still two “form → from” typos in this prompt block

Spelling consistency was the goal of this PR; these two leftover typos slipped through.

-    - Take into account all the processed data form the sources.
-    - The output should be determined from the processed data form the resolution sources.
+    - Take into account all the processed data from the sources.
+    - The output should be determined from the processed data from the resolution sources.

302-305: Minor wording: “reason” → “reasoning” for clarity

-    - **Clarity:** Make sure your reason is easy to understand.
+    - **Clarity:** Make sure your reasoning is easy to understand.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 128e60f and 2fc1abe.

📒 Files selected for processing (6)
  • frontend/scripts/contract-examples.js (1 hunks)
  • frontend/src/components/JsonViewer/json-box.vue (2 hunks)
  • frontend/src/hooks/useWebSocketClient.ts (1 hunks)
  • frontend/test/unit/hooks/useWebSocketClient.test.ts (1 hunks)
  • tests/integration/icontracts/contracts/intelligent_oracle.py (1 hunks)
  • tests/integration/icontracts/ideas.md (1 hunks)
🔇 Additional comments (6)
tests/integration/icontracts/ideas.md (1)

24-24: Typo fix looks good.

The markdown now correctly reads “standard ERC20”.

frontend/src/components/JsonViewer/json-box.vue (2)

37-39: Comment typo corrected.

No functional impact; change is fine.


57-58: Spelling fix acknowledged.

Thanks for tightening up the comments.

frontend/test/unit/hooks/useWebSocketClient.test.ts (1)

49-51: Test expectation updated correctly.

The assertion now matches the fixed log string; tests should pass.

frontend/scripts/contract-examples.js (1)

9-12: Variable rename is correct, but ensure all usages are updated.

Declaration and cleanup now use destination.

tests/integration/icontracts/contracts/intelligent_oracle.py (1)

241-243: Typo corrected in prompt – looks good

The replacement of “individial” with “individual” cleans up the wording without touching any functional path.

@cristiam86 cristiam86 merged commit d3cdcfd into genlayerlabs:main Feb 24, 2026
1 check was pending
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.103.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants