Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces ReflectionServerV2, which enables the Genkit runtime to act as a WebSocket client for dev tools integration using JSON-RPC 2.0. The Genkit class is updated to conditionally start this server based on the GENKIT_REFLECTION_V2_SERVER environment variable. Feedback identifies a critical bug in handleCancelAction where all active actions are interrupted instead of the specific one requested, and points out an unused stream variable in handleRunAction.
xavidop
changed the title
pavelgj
reviewed
Apr 7, 2026
Collaborator
Author
|
@pavelgj can you re-review? |
pavelgj
reviewed
Apr 13, 2026
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(ReflectionServerV2.class); | ||
| private static final ObjectMapper objectMapper = new ObjectMapper(); | ||
| private static final String GENKIT_VERSION = "java/1.0.0"; |
Member
There was a problem hiding this comment.
might be a good idea to centralize this one, this version should be up to date
pavelgj
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for Reflection V2 in Genkit Java
Type of Change
Documentation
Reviewer Notes