Merged
Conversation
Merged
ErnestM1234
pushed a commit
that referenced
this pull request
Apr 23, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## gt-next@6.16.9 ### Patch Changes - Updated dependencies \[]: - gt-react@10.19.2 ## @generaltranslation/gt-next-lint@14.0.9 ### Patch Changes - Updated dependencies \[]: - gt-next@6.16.9 ## gt-react-native@10.19.2 ### Patch Changes - [#1232](#1232) [`485fa93`](485fa93) Thanks [@ErnestM1234](https://github.com/ErnestM1234)! - fix: clean up minor issues ## gt-tanstack-start@0.4.6 ### Patch Changes - Updated dependencies \[]: - gt-react@10.19.2 ## gt-react@10.19.2 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This is a minor cleanup PR for the
gt-react-nativepackage that fixes several small issues: incorrect import paths in the example app, a duplicatesetLocaleWithoutPersistcall, leftover scaffold code (multiply), and adds SSR guards forlocalStorageaccess. Theconsole.logon polyfill success is also removed, aligning with the repo's no-debug-logging policy.Confidence Score: 5/5
Safe to merge — all changes are straightforward bug fixes and cleanup with no functional regressions.
No P0 or P1 issues found. All changes are correct: import path fixes, duplicate-call elimination, SSR guard additions, scaffold removal, and removal of debug logging. The dependency array change in
useEffect(dropping the non-memoizedsetLocaleWithoutPersist) is correct and prevents a potential infinite re-render loop.No files require special attention.
Important Files Changed
localStoragein bothnativeStoreGetandnativeStoreSet, warning and returning early when running in a server-side environment wherelocalStorageis unavailable.setLocaleWithoutPersist(newLocale)call, removed it from theuseEffectdependency array (it's a non-memoized function ref), and switched the unsupported locale warning to the sharedcreateUnsupportedLocaleWarninghelper.console.logon polyfill success path (aligns with no-debug-logging rule) and simplifiedcatch (e)tocatchacross all 8 Intl try/catch blocks.multiplyfunction and its associatedGtReactNativeimport, which were never part of the intended public API.'../src/_gt/...'to'./_gt/...'— the file is already insidesrc/, so the old paths pointed to a non-existentsrc/src/_gt/directory.gt-react-nativepackage.ssrUnsupportedWarningconstant used by the new SSR guard innativeStore.ts.patchrelease forgt-react-native.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["nativeStoreGet / nativeStoreSet"] --> B{Platform.OS === 'web'?} B -- Yes --> C{typeof localStorage === 'undefined'?} C -- Yes --> D["console.warn(ssrUnsupportedWarning)\nreturn null / return"] C -- No --> E["localStorage.getItem / setItem"] B -- No --> F["GtReactNative.nativeStoreGet / nativeStoreSet"]Reviews (1): Last reviewed commit: "remove styleguide" | Re-trigger Greptile
Context used:
Learned From
generaltranslation/gt-cloud#1266
generaltranslation/gt-cloud#1240