-
Notifications
You must be signed in to change notification settings - Fork 39
Add across monad support #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed Files
|
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for the Monad blockchain within the Across protocol. It integrates Monad by configuring its specific deployment parameters, such as the spoke pool and multicall addresses, and by registering its primary stablecoin assets, USDC and USDT. This expansion enables the system to facilitate cross-chain operations involving the Monad network. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the Monad chain to the Across swapper. The changes are generally correct, introducing the necessary configurations and test cases. My feedback primarily focuses on improving code consistency and readability by sorting items in various lists, match arms, and HashSets. Adopting a consistent sorting order will enhance future maintainability. I've also included suggestions to improve the structure of the test code for better clarity.
Introduces Monad-specific logic for default gas limits and USD price feeds in Across provider. Adds a new method to select the appropriate Chainlink price feed based on the target chain, and updates gas fee calculations to use the correct feed. Includes a test for quoting USDC from Ethereum to Monad.
USDC Monad -> Ethereum
USDC Ethereum -> Monad