Skip to content

Fix validation of Range #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msullivan merged 1 commit into from
Oct 3, 2025
Merged

Fix validation of Range #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gel/_internal/_qbmodel/_pydantic/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def _validate(cls, eltype: type, value: Any) -> _range.Range[_T]:
return value

elif isinstance(value, dict):
return cls(
return _range.Range(
lower=cls._validate_bound(eltype, value["lower"]),
upper=cls._validate_bound(eltype, value["upper"]),
inc_lower=value["inc_lower"],
Expand Down
7 changes: 3 additions & 4 deletions tests/test_model_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3961,7 +3961,7 @@ def test_modelgen_save_reload_props_04(self):
self.client.save(tpr)

tpr.model_dump()
self.assertPydanticSerializes(tpr, test_pickle=False)
self.assertPydanticSerializes(tpr)

def test_modelgen_save_reload_links_01(self):
from models.orm import default
Expand Down Expand Up @@ -4908,9 +4908,8 @@ def test_modelgen_save_range_01(self):
Range(dt.date(2025, 1, 6), dt.date(2025, 2, 17)),
)

# FIXME: pickle is broken for ranges
self.assertPydanticSerializes(r, test_pickle=False)
self.assertPydanticSerializes(r2, test_pickle=False)
self.assertPydanticSerializes(r)
self.assertPydanticSerializes(r2)

def test_modelgen_save_range_02(self):
import datetime as dt
Expand Down