Fix a bunch of issues with arrays as properties#942
Merged
Conversation
Don't use DowncastingTrackedList (which I guess I will now remove in a follow-up) because we don't want it's behavior of casting things to types like `std.str`. Update the CoreSchemas of arrays, multiprops, and tuples to properly use the underlying serializers -- for array and multi prop, we want to convert to a `list`, and then run a normal pydantic list serializer on the output type. Without this, multi props of arrays wouldn't convert the interior arrays into lists (leaving them as TrackedList), which caused problems like breaking model_dump_json.
elprans
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix json_schema on arrays and multi properties.
Don't use DowncastingTrackedList (which I guess I will now remove in a
follow-up) because we don't want it's behavior of casting things to types
like
std.str.Update the CoreSchemas of arrays, multiprops, and tuples to properly use
the underlying serializers -- for array and multi prop, we want to convert
to a
list, and then run a normal pydantic list serializer on the outputtype.
Without this, multi props of arrays wouldn't convert the interior arrays
into lists (leaving them as TrackedList), which caused problems like
breaking model_dump_json.
Fixes #937