Multiple file typescript client generation#31
Open
spellicer wants to merge 2 commits into
Open
Conversation
Member
|
Thanks a lot for this new pull request. I'm quite busy on multiple front so I had no time to test and review this. I'm not very comfortable with everything template file being affected, but I think I'll take this as is anyway and improve this as part of the rewriting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as a fix for a problem I ran into with the scheme choice in the generated typescript client. I then went on to try enabling the isSingleFile=false. This is working ok in the project I'm trying this generator in, but I'm not that familiar with handlebars. The strategy I used was just toggling module information for the individual files vs. the single file templates. I then choose which templates to run by mimicking the option logic from the SingleFile template in the applyTemplates method. I employ a very naive file naming strategy depending on single vs. multiple file. When multiple file, I just name the output the template name. I would appreciate any suggestions for reworking this to make it more general.