Open
Conversation
Owner
|
@santiweight Thanks a lot for the feedback. Those are very valuable comments and helps me learn how to write better If you don't mind can I just pick and choose pieces of your PR and then commit it myself. I kind of want to maintain a theme for the blog and keep things closer to the book and therefore I have made some choices which my not entirely align with Haskell style. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a note:
this parser likely doesn't need a lexer. Looks like it is very expressable as a director parser combinator, which would be the common way to do this. Obviously, if you're following a book I understand