Open
Conversation
Co-Authored-By: LLONSIT-glitch <76764896+llonsit-glitch@users.noreply.github.com>
queueRAM
approved these changes
Mar 6, 2026
Contributor
queueRAM
left a comment
queueRAM
left a comment
There was a problem hiding this comment.
Excellent work. I'm not sure what to make of the stack sizes and overlaps and would need more time to study it. Just had a couple header questions
Contributor
There was a problem hiding this comment.
could you also add to this file prototypes for uvEnvProps, uvEnvProps2, uvEnvFunc and func_80218700?
| s32 D_802C5FC0; | ||
|
|
||
| #pragma GLOBAL_ASM("asm/nonmatchings/kernel/code_2FE40/_uvTerraDraw.s") | ||
| extern u8 D_80263060[]; |
Contributor
There was a problem hiding this comment.
Maybe move this extern u8 D_80263060[] to code_58E0.h?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the rest of kernel apart from
the single nonmatching in fx.c(now matched) and libultra. A lot of the last few files were pretty connected to each other and so I decided to group them together and was left with only 3 more kernel functions left so added matches for those as well.This also links all the BSS of the non-libultra kernel. The only weird issue I came across was with gSchedStack where it appears like entrypoint.s loads the stack at 0x802C3C90 which is 0xE8 into the sched stack, but it doesn't make sense to me to have 0xE8 padding before the start of gSchedStack and then have gSchedStack be a size of 0x1F18 (instead of 0xE8). I'm not really sure why entrypoint would be using the sched stack either so sticking to what makes more sense to me currently