Rename code_B5280 -> results and decompile#66
Merged
gcsmith merged 3 commits intogcsmith:mainfrom Feb 24, 2026
Merged
Conversation
Contributor
queueRAM
commented
Feb 22, 2026
queueRAM
commented
- Decompile func_8032DD50
- Decompile func_8032DE14
- Decompile func_8032DE74
- Decompile func_8032DF08
- Decompile func_8032E000
- Decompile func_8032E060
- Decompile func_8032E698
- Decompile func_8032E6B8
- Decompile func_8032E940
- Decompile func_8032EF10
- Decompile func_8032DD50 - Decompile func_8032DE14 - Decompile func_8032DE74 - Decompile func_8032DF08 - Decompile func_8032E000 - Decompile func_8032E060 - Decompile func_8032E698 - Decompile func_8032E6B8 - Decompile func_8032E940 - Decompile func_8032EF10
queueRAM
commented
Feb 22, 2026
src/app/results.c
Outdated
|
|
||
| // FIXME: Unk80362690_Unk0_UnkC is wrong, indexing 15 in 4-byte buffer to match | ||
| // was: temp_sw->pad8B | ||
| if ((unkC->unk2 == 3) && (unkC->pad7C[0xF] != 0)) { |
Contributor
Author
There was a problem hiding this comment.
this unkC->pad7C[0xF] is accessing beyond array bounds, but struggling to match code with struct layout
src/app/results.c
Outdated
| } | ||
| menuSetProps(); | ||
| // FIXME: unkC->pad8B | ||
| if (((unkC->unk2 != 3) || (unkC->pad7C[0xF] != 0)) && (unkC->unk2 != 6)) { |
Contributor
Author
There was a problem hiding this comment.
this unkC->pad7C[0xF] is accessing beyond array bounds, but struggling to match code with struct layout
| case 0: | ||
| if (func_8033E3A8(2) != 0) { | ||
| // FIXME: unkC->pad8A | ||
| saveFileWrite((s32)unkC->pad7C[0xE]); |
Contributor
Author
There was a problem hiding this comment.
this unkC->pad7C[0xE] is accessing beyond array bounds, but struggling to match code with struct layout
- Also rename some Unk80362690 data members
queueRAM
force-pushed
the
decomp_results
branch
from
9e45b56 to
aaa8505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.