Merged
Conversation
queueRAM
approved these changes
Feb 19, 2026
Contributor
queueRAM
left a comment
queueRAM
left a comment
There was a problem hiding this comment.
nice work! janim looks good and love all the fakematch cleanups. i learned a lot about switch blocks, default cases, and continues reading through this ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally matches func_8034A4F8 and cleans up several fake matches
A lot of tricky structs I tried following down to get more info on but couldnt get much further than func_8034A4F8 in an initial search for things, so there might be some overlap but thought it made more sense for structs to start out separate and avoid unions where possible