Skip to content

feat: update windows installer to support run as administrator at login #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

garethgeorge
Copy link
Owner

No description provided.

@homandr
Copy link
Contributor

homandr commented Jul 27, 2025

@garethgeorge, I noticed you started working on this. I spent quite a bit of time a few months ago on this and could attempt to finish it. Where I left it was pretty much working installer but with a number of caveats that I didn't find a good solution at the time. Mostly around dealing with uninstalling, upgrades, detecting single-user vs multi-user installations. There are a lot of corner cases that perhaps don't need to be addressed if they affect 1% of users. I was just trying to be as thorough as I could.

If you don't mind waiting for a couple of months, I think I could get back to working on this. I see more and more requests along these lines.

@garethgeorge
Copy link
Owner Author

Hi @homandr really appreciate your continued interest in looking at this -- yep started this PR as a brief attempt on my end to see what'd be involved in adding the ability to install as administrator, this PR is largely LLM generated. Afraid I was struggling to understand whether it's correct without gaining more context in nsis and I believe it attempted to use some features that aren't available.

All of which is to say, I'd be very appreciative if you're interested in taking this on, I'm impressed with the improvements you made so far to the Windows installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants