Assign ipv6 address before disabling SrcAndDest check #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
r4mek
reviewed
Dec 5, 2025
| if providerSpec.SrcAndDstChecksEnabled != nil && !*providerSpec.SrcAndDstChecksEnabled { | ||
| if ptr.Deref(requiredInstance.SourceDestCheck, true) { | ||
| msg := fmt.Sprintf("VM %q associated with machine %q has SourceDestCheck=%t despite providerSpec.SrcAndDstChecksEnabled=%t", | ||
| *requiredInstance.InstanceId, req.Machine.Name, *requiredInstance.SourceDestCheck, *providerSpec.SrcAndDstChecksEnabled) |
There was a problem hiding this comment.
The dereference - *requiredInstance.SourceDestCheck would panic when the value is nil.
Using ptr.Deref(requiredInstance.SourceDestCheck, true) would avoid this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR does the following
InitializeMachine()method to assign ipv6 addresses before disabling SrcAndDest check.a. This is required due to the check in
GetMachineStatus()which determines whether a machine is uninitialized. According to the check, a machine is deemed to be uninitialized if the SrcAndDest check is not disabled. This caused an issue where if MCM crashes just after disabling the SrcAndDest check for a machine, it is no longer considered an uninitialized machine andInitializeMachine()is not called for it again. This results in missing ipv6 addressesclient.AssignIpv6Addresses()againa. This is needed as
client.AssignIpv6Addresses()is additive in nature and does not tolerate duplicate callsWhich issue(s) this PR fixes:
Fixes #225
Special notes for your reviewer:
Release note: