Try PackageInfo.g as fallback if package-info.json is missing#6
Open
stertooy wants to merge 2 commits into
Open
Try PackageInfo.g as fallback if package-info.json is missing#6stertooy wants to merge 2 commits into
PackageInfo.g as fallback if package-info.json is missing#6stertooy wants to merge 2 commits into
Conversation
fingolfin
reviewed
Jul 8, 2026
Comment on lines
+112
to
+114
| rm "${TMPDIR}"/version.txt | ||
| else | ||
| echo "Using package-info.json asset" |
Member
There was a problem hiding this comment.
Why does the indentation diff?
fingolfin
approved these changes
Jul 8, 2026
fingolfin
left a comment
fingolfin
left a comment
Member
There was a problem hiding this comment.
Other than the minor nitpick about indentation, seems fine to me, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make the action work on (most) repos that don't use the
release-pkgaction.Together with PR #7 this should provide a solution to #3.