Continue PR #275 with SMAppService launch-at-login - #282
Open
matthewcorven wants to merge 15 commits into
Open
Conversation
…e monitoring - Add M-series specific SMC temperature sensors (Tp09, Tp0T, Tp05, Tg05) - Update SmcControl to fallback to M-series sensors when Intel sensors unavailable - Improve GPU monitoring to handle M-series integrated GPUs - Add GitHub Actions artifact upload for easier testing Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Changed SMCKeyInfoData.dataSize from IOByteCount (8 bytes on 64-bit) to UInt32 (4 bytes) to ensure SMCParamStruct is exactly 80 bytes as required by the SMC driver. This fixes the assertion failure on Apple Silicon Macs. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add Double.init(fromFLT:) to parse FLT (float) format temperature data - Update temperature() function to try SP78 first, then fallback to FLT - Update allUnknownTemperatureSensors() to include FLT format sensors - Fixes N/A temperature display on M-series Macs The Apple Silicon Macs use FLT (4-byte float) format for temperature sensors instead of SP78 (2-byte fixed-point) format used by Intel Macs. This change enables proper temperature reading on M1/M2/M3 Macs. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Catch all errors when trying SP78 format, not just specific error code - This ensures FLT fallback works reliably on Apple Silicon Macs - Simplifies error handling logic Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Problem: - GPU shows N/A on Apple Silicon (M-series) Macs - system_profiler doesn't provide device-id for Apple Silicon GPUs - IOAccelerator doesn't provide IOPCIMatch for Apple Silicon GPUs Solution: 1. GPU Detection (GPU.swift): - Use model name as deviceId fallback when device-id is not available - This allows Apple Silicon GPUs to be detected (e.g., "Apple M4 Pro") 2. GPU Statistics (GPU.swift): - Remove requirement for IOPCIMatch (was causing nil return) - Use "apple" as fallback pciMatch for Apple Silicon GPUs - GPU usage is available from PerformanceStatistics["Device Utilization %"] 3. GPU Matching (GpuStore.swift): - Detect Apple Silicon GPUs by checking if deviceId contains "apple" or " m" - Match Apple Silicon GPUs by pciMatch == "apple" - Keep Intel GPU matching logic (match by device ID in pciMatch) Note on GPU Temperature: - GPU temperature sensors (Tg*) exist but return SMC error 132 (read-only/unavailable) - This appears to be a system limitation on Apple Silicon - GPU temperature will show N/A, but usage percentage will work correctly Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add uptime days display in CPU menu block - Update version from 1.6.2 to 1.6.3 - Add localization support for all 22 languages Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
## Graph Bar Color - Added GraphColorOption enum with 5 options: Monochrome, Red (#e03a3e), Blue (#009ddc), Orange (#f6821f), Yellow (#fcb827) - EulComponentConfig now stores graphColor setting, persisted to UserDefaults - LineChart accepts a color parameter (fill at 50% opacity, solid stroke) - CpuView, GpuView, MemoryView pass config.graphColor.color to LineChart - PreferenceComponentConfigView shows a color picker row (circle swatches) when 'Show Graph' is enabled — clicking a swatch applies it instantly ## Color Definitions - Added .graphRed, .graphBlue, .graphOrange, .graphYellow to Color extension - ProgressBarView now accepts a color parameter for bar fill (default .primary) ## Apple Silicon / Build Fixes - Bumped MACOSX_DEPLOYMENT_TARGET from 10.15 → 11.0 for all targets - Disabled SwiftFormat build phase (was blocking build by downloading SPM deps) - Suppressed noisy SMC error 135 (SP78/FLT type mismatch on Apple Silicon — already handled by FLT fallback, was printing on every refresh cycle)
Continue the Apple Silicon and modern Xcode work from PR gao-sun#275 by removing the LaunchAtLogin helper dependency and switching the preference toggle to ServiceManagement.SMAppService.mainApp. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is intended as a continuation of #275 by @nastarynaz rather than an independent rewrite. The Apple Silicon support, graph color picker work, deployment-target update, and build-script cleanup come from that earlier PR; this follow-up carries that work forward by replacing the remaining Intel-only login-item helper path with a modern macOS implementation.
Specifically, this change removes the
LaunchAtLoginpackage and switches the preference toggle toServiceManagement.SMAppService.mainApp.What changed
LaunchAtLoginSwift package from the Xcode projectCopy LaunchAtLogin helperbuild phaseLaunchAtLoginpin fromPackage.resolvedPreferenceGeneralViewwith anSMAppService.mainApp-backed storeLaunchAtLoginHelper.appWhy this follow-up is needed
After building the #275 branch on Apple Silicon, the app still shipped an embedded
LaunchAtLoginHelper.appthat wasx86_64-only. That produces macOS warnings about Intel-only components even though the main app and its extensions arearm64.Using
SMAppService.mainAppremoves that helper entirely and aligns launch-at-login support with modern macOS behavior.Build and signing notes
Unsigned CLI build
For a compile-only build without local signing setup:
Signed Xcode build
To test launch-at-login end to end, open
eul.xcodeprojin Xcode and use a valid Apple development signing identity:eulproject.A signed build is required to verify the launch-at-login behavior in the running app.
Validation
xcodebuildcompile with signing disabled succeedsLaunchAtLoginHelper.apporLaunchAtLogin_LaunchAtLogin.bundleAttribution
Please treat this PR as building directly on top of the work in #275 by @nastarynaz.