Skip to content

Conversation

@d-callan
Copy link
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @d-callan! Small comments inline.

d-callan and others added 2 commits December 2, 2025 10:09
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
@bgruening
Copy link
Member

There is another small problem, where I don't have a good answer ... currently all inputs are optional. Is that true? In theory, a user can submit a tool without any inputs ... :(

@d-callan
Copy link
Contributor Author

d-callan commented Dec 2, 2025

yea i debated this^ w myself a lot while drafting this and kept waffling. i could make all but cfel and relax required and id guess the vast majority of time that wont stop anyone meaningfully using this. the intended use is that youll have either four json, or all six. but hyphy if a particular method fails for a particular gene wont produce a json. so you can have situations where you have three input json for a gene, and drhip is meant to be flexible to that case. itll just report what it can for what it was passed. im not sure i know whatd itd do if you tried to pass it nothing though 😂

@d-callan
Copy link
Contributor Author

d-callan commented Dec 3, 2025

ok. ive left the inputs optional, which feels odd i know, but ive tried to clarify in the help text what the intended use is at least. if it helps at all, i expect this is most useful in workflows or something where youre running many hyphy methods over many genes simultaneously or similar and the likelihood of empty inputs in that context are low. also ive confirmed if you do try to run it w no input files, say someone just poking around curious, it should fail w a useful error.

otherwise, ive updated drhip and am producing tabular outputs now w passing tests for column counts. if wed like an issue for the same tests failing w csv, let me know where it makes most sense to file one..

@d-callan
Copy link
Contributor Author

d-callan commented Dec 4, 2025

related, see galaxyproject/galaxy#21391

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Do you think we should fail the tool fast in case no input is provided? Or does it already fail very fast - I assume so.

@d-callan
Copy link
Contributor Author

d-callan commented Dec 4, 2025

it should fail pretty quickly, yes. basically the first real work it tries to do is put together a list of genes present across all files, and if it cant find any files to look through, itll say so.

@bgruening bgruening merged commit 15c654c into galaxyproject:main Dec 4, 2025
11 checks passed
@d-callan d-callan deleted the drhip branch December 4, 2025 15:04
@mvdbeek
Copy link
Member

mvdbeek commented Dec 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants