-
Notifications
You must be signed in to change notification settings - Fork 494
add drhip #7490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add drhip #7490
Conversation
bgruening
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @d-callan! Small comments inline.
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
|
There is another small problem, where I don't have a good answer ... currently all inputs are optional. Is that true? In theory, a user can submit a tool without any inputs ... :( |
|
yea i debated this^ w myself a lot while drafting this and kept waffling. i could make all but cfel and relax required and id guess the vast majority of time that wont stop anyone meaningfully using this. the intended use is that youll have either four json, or all six. but hyphy if a particular method fails for a particular gene wont produce a json. so you can have situations where you have three input json for a gene, and drhip is meant to be flexible to that case. itll just report what it can for what it was passed. im not sure i know whatd itd do if you tried to pass it nothing though 😂 |
|
ok. ive left the inputs optional, which feels odd i know, but ive tried to clarify in the help text what the intended use is at least. if it helps at all, i expect this is most useful in workflows or something where youre running many hyphy methods over many genes simultaneously or similar and the likelihood of empty inputs in that context are low. also ive confirmed if you do try to run it w no input files, say someone just poking around curious, it should fail w a useful error. otherwise, ive updated drhip and am producing tabular outputs now w passing tests for column counts. if wed like an issue for the same tests failing w csv, let me know where it makes most sense to file one.. |
|
related, see galaxyproject/galaxy#21391 |
bgruening
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Do you think we should fail the tool fast in case no input is provided? Or does it already fail very fast - I assume so.
|
it should fail pretty quickly, yes. basically the first real work it tries to do is put together a list of genes present across all files, and if it cant find any files to look through, itll say so. |
|
Deployment status: success https://github.com/galaxyproject/tools-iuc/actions/runs/19933346729 |
FOR CONTRIBUTOR: