Skip to content

Add compress option pairtool wrapper #7127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Smeds
Copy link
Contributor

@Smeds Smeds commented Jul 9, 2025

This update adds support for compressed input and output in the pairtools wrapper. Since pairtools determines whether to use compression based on the file extension—which must be .gz—the wrapper has been updated to automatically create input and output links with the appropriate .gz suffix.

For output, compression can be enabled by setting the compress_output parameter to true, ensuring that the generated output link ends with .gz. For input, the wrapper depends on the file types being 4dn_pairs.gz or 4dn_pairsam.gz, which ensures that the input files also have the required .gz extension.

This pull-request have new data types that currently aren't in the galaxy repository, which will result in failed tool linting.

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@Smeds
Copy link
Contributor Author

Smeds commented Jul 9, 2025

Pull-request #20634 will add the new formats used by this update.

@Smeds Smeds force-pushed the compress-option-pairtool branch from 9d392b7 to d91be75 Compare July 16, 2025 17:45
@Smeds
Copy link
Contributor Author

Smeds commented Jul 16, 2025

@nsoranzo I have updated the tool wrapper according to your comments. It will now rely more in the input format to decide if the output will be compressed, except for parse which generate the pairsam files. The linting is still failing and I guess it will do that until the format update is moved into the master branch.

@Smeds Smeds closed this Jul 17, 2025
@Smeds Smeds reopened this Jul 17, 2025
@Smeds Smeds mentioned this pull request Jul 18, 2025
5 tasks
@Smeds
Copy link
Contributor Author

Smeds commented Jul 18, 2025

@nsoranzo when is galaxy-tool-util update. Looks like this library needs update for my pull-request to pass the linting.

@Smeds Smeds closed this Jul 22, 2025
@Smeds Smeds reopened this Jul 22, 2025
@Smeds
Copy link
Contributor Author

Smeds commented Jul 23, 2025

@nsoranzo @mvdbeek @jmchilton Would it be possible to get a new release of galaxy-tool-util with the updated pairtool datatype?

And if we need to wait for the next release. Could someone approve this pull-request even though the linting fails?

@Smeds Smeds requested a review from nsoranzo July 23, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants