-
Notifications
You must be signed in to change notification settings - Fork 475
new tool: galaxy wrappers for the pcdl physicell data lader command line commands #7034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elmbeech thanks! I added a few comments that apply for all tools. I think a macro file and a proper formatting will help a lot for further reivew.
Please have a look at the Galaxy Language Server, it has some build-in tools for auto-formatting.
This comment was marked as resolved.
This comment was marked as resolved.
Sure. https://planemo.readthedocs.io/en/latest/writing_advanced.html#macros-reusable-elements |
i think you mean: ``` type="boolean" truevalue="" falsevalue="--microenv false" checked="true" ``` Co-authored-by: Björn Grüning <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
You can find the xunit/error reports here: https://github.com/galaxyproject/tools-iuc/actions/runs/16511690042?pr=7034 When one test files with error code 1, planemo should not fail, you probably want to know what the others tests do, if they also fail or if only test 1 fails. |
Looking at your error report it seems some test files are missing:
etc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice @elmbeech!
I added a bunch of comments that should improve future updates but also UX for the user. Please let me know if you have any questions.
This comment was marked as resolved.
This comment was marked as resolved.
You need to go to the CI summary page, this one: https://github.com/galaxyproject/tools-iuc/actions/runs/16556891445?pr=7034 Than you see: ![]() you still have a lot of files missing:
|
Please see my last comment, I think this explains your failing tests. |
ogge! now the test are passing :"). |
Please let me know when you think you are ready. |
@bgruening i think it is ready. |
Great, I will try to have a look asap again. This is a really nice set of tools, thanks a lot! |
thank you for the appreciation! |
thank you for all your help with the PR! |
You picked the IUC battle, rigorous reviews and annoying dudes that care about UX :) If you like use |
Thank you, Bjoern! |
Step 3 of https://usegalaxy-eu.github.io/posts/2020/08/22/three-steps-to-galaxify-your-tool/ if you like :) |
Merci!!! |
hi @bgruening , I hope you still see this message. Somehow, naively, I thought when I merge my tools into the tools-iuc repo, they will become avaliable in at https://galaxy.eu and https://usegalaxy.org/ . But when I am searching for them in the "search tools" bar or in the panel below, I cannot find them. Could you please point me to the documentation where I can learn how to use the pcdl tools online at galaxy eu or usa? Or are these tools only for use on a local installation? thank you, Elmar |
See my last message, step 3 ;-) Your tool is now in our App store and can be installed by all admins. However, admins are able to decide what goes in. |
Thank you Bjoern, for that swift reply! |
i think first just Europe. |
FOR CONTRIBUTOR: