Fix cummeRbund and various linting errors #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caused by the removal of the ``file_name`` property in galaxyproject/galaxy#16783 . Fix these errors: ``` Parameter 'x': requires a value, but no legal values defined, Parameter 'y': requires a value, but no legal values defined ``` ``` Parameter 'gene_id': requires a value, but no legal values defined ```
to fix `Mutex creation failed` when importing `later`, xref: r-lib/later#63 cummeRbund 2.24.0 is the first version that doesn't (indirectly) depend on `r-later` and works correctly.
nsoranzo
force-pushed
the
fix_cummeRbund_and_linting_errors
branch
2 times, most recently
from
2dd7aa5 to
38e5d6c
Compare
nsoranzo
force-pushed
the
fix_cummeRbund_and_linting_errors
branch
from
38e5d6c to
ff8ab28
Compare
Member
Author
|
Green! This should fix the weekly CI tests. |
bgruening
reviewed
Dec 12, 2025
| <output name="output" ftype="txt"> | ||
| <assert_contents><has_text text="cummeRbund finished" /></assert_contents> | ||
| <discovered_dataset designation="maplot-0" ftype="png" file="maplot.png" /> | ||
| <discovered_dataset designation="maplot-0" ftype="png" file="maplot.png" compare="sim_size" /> |
Member
There was a problem hiding this comment.
you can use here the more stringent img-comparison asserts
Member
Author
There was a problem hiding this comment.
I think I've tried that and the difference was very high for reasons I don't understand.
Co-authored-by: Björn Grüning <[email protected]>
nsoranzo
force-pushed
the
fix_cummeRbund_and_linting_errors
branch
from
f1d5f3e to
f0984b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.