Skip to content

Commit f0984b8

Browse files
nsoranzobgruening
andcommitted
Apply suggestions from code review
Co-authored-by: Björn Grüning <[email protected]>
1 parent ff8ab28 commit f0984b8

File tree

3 files changed

+27
-13
lines changed

3 files changed

+27
-13
lines changed

tools/condense_characters/condense_characters.xml

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
1-
<tool id="Condense characters1" name="Condense" version="1.0.1">
1+
<tool id="Condense characters1" name="Condense" version="1.0.1" profile="24.0">
22
<description>consecutive characters</description>
3+
<requirements>
4+
<requirement type="package" version="5.32">perl</requirement>
5+
</requirements>
6+
<required_files>
7+
<include path="condense_characters.pl" />
8+
</required_files>
39
<command>
4-
perl $__tool_directory__/condense_characters.pl
5-
"${input}"
6-
"${character}"
7-
"${out_file1}"
10+
perl '$__tool_directory__/condense_characters.pl'
11+
'${input}'
12+
${character}
13+
'${out_file1}'
814
</command>
915
<inputs>
1016
<!-- <display>condense all consecutive $character from $input</display> -->
@@ -30,7 +36,6 @@
3036
</test>
3137
</tests>
3238
<help>
33-
3439
**What it does**
3540

3641
This tool condenses all consecutive characters of a specified type.

tools/cummerbund/cummeRbund.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<tool id="cummeRbund" name="cummeRbund" version="@TOOL_VERSION@+galaxy0">
2+
<tool id="cummeRbund" name="cummeRbund" version="@TOOL_VERSION@+galaxy0" profile="24.0">
33
<description>visualize Cuffdiff output</description>
44
<macros>
55
<import>cummeRbund_macros.xml</import>
@@ -10,6 +10,9 @@
1010
<requirement type="package" version="3.5.1">r-base</requirement>
1111
<requirement type="package" version="@TOOL_VERSION@">bioconductor-cummerbund</requirement>
1212
</requirements>
13+
<required_files>
14+
<include path="cummeRbund.R" />
15+
</required_files>
1316
<code file="cummeRbund_options.py"/>
1417
<command detect_errors="aggressive">
1518
<![CDATA[

tools/remove_beginning/remove_beginning.xml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,19 @@
1-
<tool id="Remove beginning1" name="Remove beginning" version="1.0.1">
1+
<tool id="Remove beginning1" name="Remove beginning" version="1.0.1" profile="24.0">
22
<description>of a file</description>
3+
<requirements>
4+
<requirement type="package" version="5.32">perl</requirement>
5+
</requirements>
6+
<required_files>
7+
<include path="remove_beginning.pl" />
8+
</required_files>
39
<command>
4-
perl $__tool_directory__/remove_beginning.pl
5-
"${input}"
6-
"${num_lines}"
7-
"${out_file1}"
10+
perl '$__tool_directory__/remove_beginning.pl'
11+
'${input}'
12+
${num_lines}
13+
'${out_file1}'
814
</command>
915
<inputs>
10-
<param name="num_lines" type="integer" value="1" label="Remove first" help="lines"/>
16+
<param name="num_lines" type="integer" min="0" value="1" label="Remove these number of lines from the top"/>
1117
<param format="txt" name="input" type="data" label="from"/>
1218
</inputs>
1319
<outputs>

0 commit comments

Comments
 (0)