Skip to content

Drop stdout and stderr from message status #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 13, 2025

These may be large and are transferred as files anyway.

Should fix #384

@mvdbeek mvdbeek force-pushed the drop_stdout_stderr_message_status branch from c1f7dfb to c3e8f71 Compare March 13, 2025 16:39
@jmchilton
Copy link
Member

This should to be done in a backward compatible way right? Like if Galaxy knows the files will be transferred and read - it sets up a param that indicates not to transfer these? Or is it time to admit we don't have the energy to keep these things working with older Galaxies?

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 13, 2025

I have the vague idea that this should have been working for a couple of years now ? I'll check

@jmchilton
Copy link
Member

The failing install_wheel test seems relevant.

@mvdbeek mvdbeek force-pushed the drop_stdout_stderr_message_status branch from c3e8f71 to 9ddc22a Compare March 13, 2025 16:48
@jmchilton
Copy link
Member

Even dropping the 8MB message to 64KB seems like it would fix any potential problems right - while keeping the API largely in tact? You're doing the work - I'll let you do whatever - maybe I'm too precious about the Pulsar API.

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 13, 2025

Should be 6 years, I think (counting from galaxyproject/galaxy#8625). I suppose if you run a Galaxy that old it's unlikely you'll be running a brand new pulsar ?

These may be large and are transferred as files anyway.
@mvdbeek mvdbeek force-pushed the drop_stdout_stderr_message_status branch from 9ddc22a to 83b1bc1 Compare March 13, 2025 16:57
@jmchilton
Copy link
Member

I trust you.

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 13, 2025

Let's see how the tests are going, but I agree, let's do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status update publisher dies on oversize message
3 participants