Assorted tool shed fixes. #21424
Merged
Assorted tool shed fixes. #21424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
kind/bug
area/UI-UX
area/toolshed
area/toolshed-2.0
Handle API errors in ToolVersionPage - display error message with guidance to reset repository metadata instead of spinning forever. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Discard stale search results when a newer search has been initiated. Prevents out-of-order responses from overwriting correct results. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Persist search query and page number in URL for browser back/forward navigation and shareable links. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add clearable button and delete key handler to SelectUser component. Emit cleared event so parent can reset state. Note: galaxyproject#21413 not fully resolved - the textbox+select combo remains unintuitive. Users still expect backspace to work like a text input. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Skip link + landmarks (App.vue): role="banner", role="main", skip-to-content - Focus indicators: global :focus-visible CSS - Live regions: ErrorBanner role="alert", LoadingDiv role="status" - Toolbar: aria-haspopup on dropdowns, aria-label on icon buttons - FABs: aria-label on all FAB triggers (4 components) - Table: aria-label on PaginatedRepositoriesGrid - CLAUDE.md: document accessibility patterns 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Login errors now display via ErrorBanner (role="alert", aria-live="assertive") instead of toast notifications, ensuring screen readers announce failures. - LoginForm: catch errors locally, display inline ErrorBanner - auth.store: use await/throw instead of .catch(notifyOnCatch) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- /api_internal proxy for login/logout endpoints - /backend_session proxy to get session_csrf_token cookie - README: document visiting /backend_session before login 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Fix rowsPerPage computed ref not being unwrapped in pagination object - Add watcher to sync rowsPerPage when route query changes - Add CSS ellipsis truncation for long repository descriptions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
jmchilton
force-pushed
the
toolshed_2_2
branch
from
d77d12d to
e2fa795
Compare
Member
|
Thank you @jmchilton! @natefoo can you deploy this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool Shed 2.1 Frontend Bug Fixes
Fixes several UI bugs reported in the new Tool Shed frontend.
Changes
More changes after that:
WCAG 2.1 AA accessibility improvements for Tool Shed frontend (xref #21412)
role="alert"andaria-live="assertive"to ErrorBannerrole="status"andaria-live="polite"to LoadingDivaria-haspopupandaria-labelto toolbar buttons/dropdownsaria-labelto FABs in RepositoryExplore, RepositoryActions, RevisionActions, RepositoryHealtharia-labelto PaginatedRepositoriesGrid table:focus-visiblestylesAdd accessible error announcements to login form (xref #21412)
Add proxy for external backend login in dev mode
/api_internaland/backend_sessionproxies in vite.config.ts/backend_sessionrewrites to backend root to set session_csrf_token cookieI had Cursor exercise the UI and offer up random usability improvements
Fix pagination "len" label bug and add description truncation
How to test the changes?
(Select all options that apply)
License