-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove unused javascript from toolshed test makos #21387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jmchilton
merged 22 commits into
galaxyproject:dev
from
guerler:remove_unused_js_from_toolshed_makos
Dec 12, 2025
Merged
Remove unused javascript from toolshed test makos #21387
jmchilton
merged 22 commits into
galaxyproject:dev
from
guerler:remove_unused_js_from_toolshed_makos
Dec 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d9e3c5 to
45dbbf8
Compare
c7062f8 to
15578b1
Compare
a844014 to
949c977
Compare
Member
|
Lovely - red is my favorite color of code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/testing
area/toolshed
kind/refactoring
cleanup or refactoring of existing code, no functional changes
minor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused and invalid javascript fragments embedded in the legacy toolshed makos that remain only as test fixtures. The runtime toolshed interface no longer references these templates due to the migration to the modern client, and the javascript blocks no longer match any active initialization path. This change strips the dead sections while preserving the minimal structure required for the tests that still load these files. The goal is to improve clarity in preparation for future toolshed work.
How to test the changes?
(Select all options that apply)
License