-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Explore Upload Activity Redesign #21338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
davelopez
wants to merge
36
commits into
galaxyproject:dev
Choose a base branch
from
davelopez:explore_upload_activity
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34c64f0 to
995661d
Compare
jmchilton
reviewed
Nov 25, 2025
This way we can have more control about the content, how to validate it, suggest using deferred data, etc.
Name and description already cover the same words for searching so no need for it for now.
Introduces a registry-driven upload method architecture, enabling dynamic selection and configuration of upload types. Moves upload logic into modular, async-loaded components. Lays groundwork for easier extensibility, improved user experience, and future integration of new import workflows.
Introduces a flexible UI component for displaying informational, warning, success, or danger tips with markdown formatting. Enhances user guidance and maintains consistent styling across the app.
Improves user feedback during file uploads by introducing a visual upload progress indicator in the upload panel header and a detailed modal displaying individual file upload statuses, progress, and errors.
Introduces controls for file extension, dbkey, whitespace, line endings, and deferred upload options to enhance flexibility and consistency for local file uploads. Integrates upload service to handle file enqueueing with user-specified metadata.
Collections should be offered in each activity when there are more than 1 files selected for upload.
Moves upload method selection to dedicated route.
Avoiding flickering when the status changes quickly.
To ensure the global drop zone does not interfere with the local drop zone.
995661d to
56bb2d1
Compare
Modernizes file upload modules with strong typing. Improves test coverage and updates imports across affected components for consistency.
Migrates upload payload construction to a strongly-typed module. Replaces legacy, ad-hoc payload building with explicit type-safe builders and helpers, cleaning up API boundaries and reducing conversion ambiguity between UI and API models. Aims for improved reliability and future extensibility of dataset upload features.
56bb2d1 to
f371854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early draft to explore the UI. Let's discuss the redesign here #21340
How to test the changes?
(Select all options that apply)
License