[25.1] Add a debounce to text form elements to prevent values from resetting #21300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedhamidawan
changed the title
Member
|
The test errors look legitimate to me. Maybe debounce is not the right thing? it seems that other fields are fine, is that maybe because |
We have a bug where in the workflow editor, while typing in a text form element, the value can get unexpectedly trimmed or reset because of the `build_module` API call updating the values. Adding a debounce of 1 second solves this problem; as we now wait for the user to type out their entire value first. This debounce is set if the `workflowBuildingMode` prop is set for `FormElement`. Fixes galaxyproject#21205
ahmedhamidawan
force-pushed
the
debounce_form_element_text_input
branch
from
ced3fd1 to
f4528ed
Compare
Member
Author
|
I tried a slightly different approach thought it is still via a debounce. Seleniums are still failing (though fewer fails than earlier) and possibly related? Will investigate the fails to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bug where in the workflow editor, while typing in a text form element, the value can get unexpectedly trimmed or reset because of the
build_moduleAPI call updating the values. Adding a debounce of 1 second solves this problem; as we now wait for the user to type out their entire value first.This debounce is set if the
workflowBuildingModeprop is set forFormElement.Fixes #21205
debounce_form_element_text_input_BEFORE.mp4
debounce_form_element_text_input_AFTER.mp4
How to test the changes?
(Select all options that apply)
License