-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update error message handling for OIDC #21297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hi @nuwang @bgruening, can you help with getting this UX improvement in? Kind Regards, |
nuwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Server side changes look ok to me, thanks @uwwint. Have left some minor comments. @ahmedhamidawan Would you be able to review front-end changes please?
Thank you @nuwang and @uwwint , I can run this locally and test out several use cases. It might take me towards the end of the week because of the Galaxy Team Meeting right now. |
Co-authored-by: Nuwan Goonasekera <[email protected]>
lint whitespace
9feed6c to
3477af1
Compare
ahmedhamidawan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client changes look good to me!
@uwwint please run the following commands to lint the backend before you commit your changes:
% make format && tox -e lint && tox -e mypyAnd the following for client side changes:
% cd client && yarn run prettier --check
% cd client && yarn run eslint
Change OIDC error handling. In case error_description is provided to the callback render that message to the user instead of the default text in Galaxy. Also update the UI to kick the user back to the login screen with the usual error handling
How to test the changes?
(Select all options that apply)
License