Skip to content

Conversation

@uwwint
Copy link
Contributor

@uwwint uwwint commented Nov 14, 2025

Change OIDC error handling. In case error_description is provided to the callback render that message to the user instead of the default text in Galaxy. Also update the UI to kick the user back to the login screen with the usual error handling

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. configure an OIDC provider
    2. login with a user into the OIDC provider which triggers an error
    3. Observe the error is shown on the login screen. if the callback parameter error_description is not provided, the standard galaxy message is shown.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.
Screenshot 2025-11-14 at 13 47 57

@github-actions github-actions bot added this to the 26.0 milestone Nov 14, 2025
@uwwint
Copy link
Contributor Author

uwwint commented Nov 16, 2025

Hi @nuwang @bgruening,

can you help with getting this UX improvement in?

Kind Regards,
Uwe

Copy link
Member

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server side changes look ok to me, thanks @uwwint. Have left some minor comments. @ahmedhamidawan Would you be able to review front-end changes please?

@ahmedhamidawan ahmedhamidawan changed the title update error message handling for OIDC Update error message handling for OIDC Nov 18, 2025
@ahmedhamidawan
Copy link
Member

Server side changes look ok to me, thanks @uwwint. Have left some minor comments. @ahmedhamidawan Would you be able to review front-end changes please?

Thank you @nuwang and @uwwint , I can run this locally and test out several use cases. It might take me towards the end of the week because of the Galaxy Team Meeting right now.

@ahmedhamidawan ahmedhamidawan self-requested a review November 22, 2025 20:58
@ahmedhamidawan ahmedhamidawan force-pushed the feature/oidc_error_handling branch from 9feed6c to 3477af1 Compare November 22, 2025 21:07
Copy link
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client changes look good to me!

@uwwint please run the following commands to lint the backend before you commit your changes:

% make format && tox -e lint && tox -e mypy

And the following for client side changes:

% cd client && yarn run prettier --check
% cd client && yarn run eslint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants