Move js-client bootstrapping to FastAPI #21264
Open
+1,237
−1,532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
added
area/UI-UX
kind/refactoring
guerler
changed the title
mvdbeek
reviewed
Nov 10, 2025
mvdbeek
reviewed
Nov 10, 2025
mvdbeek
reviewed
Nov 10, 2025
| @router.cbv | ||
| class FastAPIContext: | ||
| @router.get("/api/context", summary="Return bootstrapped client context") | ||
| def index(self, request: Request, trans: ProvidesUserContext = DependsOnTrans) -> JSONResponse: |
Member
There was a problem hiding this comment.
Design-wise I think it would be a good idea to make this as static as possible so we can heavily cache the response. fetch all the user-specific stuff later ?
Contributor
Author
There was a problem hiding this comment.
Agreed, this is an initial very rough draft. We should remove unnecessary parts and keep it as minimal as possible. It may eventually fit into the configuration API, but it’s too early to decide.
guerler
force-pushed
the
remove_js_app_mako
branch
12 times, most recently
from
4bf45df to
6221dbe
Compare
guerler
changed the title
guerler
force-pushed
the
remove_js_app_mako
branch
8 times, most recently
from
569fd5e to
6f63b93
Compare
4 tasks
guerler
force-pushed
the
remove_js_app_mako
branch
from
f2c05ab to
0791c4e
Compare
guerler
force-pushed
the
remove_js_app_mako
branch
from
13effcd to
7ae3cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #17507. Resolves: #21153. This PR removes the legacy RxJS-based initialization and Mako-injected configuration bootstrapping, replacing them with a straightforward async startup flow. Configuration is now fetched directly from the
/api/contextendpoint, after which theGalaxyAppis instantiated, registered viasetGalaxyInstance, and initialized withSentryandWebhooks. The Vue app mounts deterministically without relying on reactive queues or template timing, simplifying the client bootstrap and removing obsolete RxJS and Mako dependencies.How to test the changes?
(Select all options that apply)
License