Skip to content

Conversation

@guerler
Copy link
Contributor

@guerler guerler commented Oct 25, 2025

This PR switches to @vue/compat to see how many errors and warnings we get (heads up...quite a few 😅). The idea is to have a baseline so we can start picking off issues in small PRs. These PRs against dev could be merged immediately since they wouldn’t include the compat switch.

The main goal is to speed up merging #20787 by breaking it into smaller chunks. This strategy could reduce conflicts with other PRs and the risk of stale branches. People can check out this branch, fix errors/warnings in small PRs against dev, and then we rebase this compat branch weekly. That way we can track progress. I will also try to categorize the errors and warnings to make it easier to pick issues. Some errors might need to wait until we fully switch to Vue 3, but many should be fixable in dev even without Vue 3.

webpack 5.99.7 compiled with 559 errors and 154 warnings in 24003 ms

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 26.0 milestone Oct 25, 2025
@dannon
Copy link
Member

dannon commented Oct 25, 2025

@guerler All of the build errors were fixed in that branch fairly recently. I will rebase again, remember the sticking point was the forced jest test migration due to vue-test-utils incompatibility. Before we spend more time redoing work that is already done, lets' dicsuss in the weekly call?

@guerler guerler force-pushed the switch_to_compat_mode branch from d676f31 to 0e3ffbc Compare October 26, 2025 05:51
@guerler guerler force-pushed the switch_to_compat_mode branch from 0e3ffbc to 20e31f8 Compare November 25, 2025 14:51
@guerler
Copy link
Contributor Author

guerler commented Nov 25, 2025

webpack 5.99.7 compiled with 349 errors and 400 warnings in 77020 ms

with latest dev at: 426fcd1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants