Skip to content

Unify History export UX using wizard #20666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 22, 2025
Merged

Unify History export UX using wizard #20666

merged 9 commits into from
Jul 22, 2025

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Jul 15, 2025 •
edited
Loading

This redesigns the History Export component to align it more closely with the Workflow Invocation Export component, thereby unifying the export user experience.

First time export

image

History with recent exports

image

Previous export records

image

TODO

  • Adapt tests and/or increase coverage

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

davelopez added 5 commits July 15, 2025 17:46
@davelopez
Refactor remove readonly modifiers from ExportParams
e99bae2 
Keep readonly in ExportRecord
@davelopez
Add HistoryExportWizard component
19f2a14
@davelopez
Refactor ExportRecordTable component
7b26bb7 
Simplify component and remove collapsible to leave it as a simple table.
@davelopez
Refactor ExportRecordDetails component
89b1ec2 
To use GCard
@davelopez
Redesign HistoryExport component
10a46c1 
Enhance UX with HistoryExportWizard to make it more consistent with Invocation Exports and use GModal for old records
@davelopez davelopez added kind/enhancement area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Jul 15, 2025
@davelopez
Update GCard references in ExportRecordDetails.vue
0338af2 
- Remove redundant 'visible' property after GCard default values update
- Use new action types for GCard
@davelopez davelopez force-pushed the history_export_wizard branch from a6e8bf3 to 0338af2 Compare July 15, 2025 16:15
@davelopez davelopez marked this pull request as ready for review July 17, 2025 12:32
@github-actions github-actions bot added this to the 25.1 milestone Jul 17, 2025
@jmchilton
Copy link
Member

Rerunning failed selenium test - doesn't seem related but I don't recall seeing it fail recently and it is the history component.

lib/galaxy_test/selenium/test_histories_published.py::TestPublishedHistories::test_published_histories_tag_click

jmchilton
jmchilton approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

itisAliRH
itisAliRH approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@itisAliRH itisAliRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davelopez!

@itisAliRH itisAliRH merged commit 039e845 into galaxyproject:dev Jul 22, 2025
63 of 67 checks passed
@davelopez davelopez deleted the history_export_wizard branch July 22, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

@itisAliRH itisAliRH itisAliRH approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
25.1
Development

Successfully merging this pull request may close these issues.
3 participants
@davelopez @jmchilton @itisAliRH