Add new ODV datatype #20581
Open
Add new ODV datatype #20581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocean Data View format is used in ODV interactive tool.
bgruening
reviewed
Jun 28, 2025
lib/galaxy/datatypes/text.py
Outdated
| def sniff(self, filename): | ||
| try: | ||
| with open(filename, "r", encoding="utf-8") as f: | ||
| for line in f: |
There was a problem hiding this comment.
Please do not iterate over the entire file. Use sniff_prefix() or restrict your iteration to a few lines.
bgruening
reviewed
Jun 28, 2025
lib/galaxy/datatypes/text.py
Outdated
|
|
||
| elif section == "Meta Variables": | ||
| name = value.split(";")[0].strip() | ||
| dataset.metadata.meta_variables.append(name) |
There was a problem hiding this comment.
How big can this be? Should we also prevent it from adding Millions of entries etc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ocean Data View format is used in ODV interactive tool.
How to test the changes?
(Select all options that apply)
License