Skip to content

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 24, 2025

Such as those made by Database Operation or expression tools.

Should fix the issue we had during Galaxy live, where we had a step in which we picked the first dataset collection element from a mapped over collection whose outputs where not yet replaced by the job cache.

The effect of this is that the extracted dataset's dataset was deleted, and all downstream jobs where waiting for this dataset to become terminal.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added the area/database Galaxy's database or data access layer label Jun 24, 2025
@mvdbeek mvdbeek force-pushed the live_fix_cry_emoji branch from 870e7f6 to d613247 Compare June 26, 2025 15:52
mvdbeek added 4 commits July 21, 2025 18:37
…peration tools)

Should fix the issue we had during Galaxy live, where we had a step in
which we picked the first dataset collection element from a mapped over
collection whose outputs where not yet replaced by the job cache.

The effect of this is that the extracted dataset's dataset was deleted,
and all downstream jobs where waiting for this dataset to become
terminal.
@mvdbeek mvdbeek force-pushed the live_fix_cry_emoji branch from a72048c to b691b93 Compare July 23, 2025 15:44
@mvdbeek mvdbeek changed the base branch from dev to release_25.0 July 23, 2025 15:45
@github-actions github-actions bot changed the title Propagate cached job output replacement to copies (made by database o… [25.0] Propagate cached job output replacement to copies (made by database o… Jul 23, 2025
@mvdbeek mvdbeek changed the title [25.0] Propagate cached job output replacement to copies (made by database o… [25.0] Propagate cached job output replacement to copies of outputs Jul 23, 2025
@mvdbeek mvdbeek marked this pull request as ready for review July 23, 2025 15:46
@github-actions github-actions bot added this to the 25.1 milestone Jul 23, 2025
@mvdbeek mvdbeek requested review from jmchilton and a team July 23, 2025 15:47
@jmchilton jmchilton merged commit 7769f63 into galaxyproject:release_25.0 Jul 29, 2025
62 of 66 checks passed
@jmchilton
Copy link
Member

Very sorry I let this slip through the cracks. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants