(Re)move job_conf.xml.sample_advanced
#20406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
force-pushed
the
del_job_conf.xml.sample_advanced
branch
2 times, most recently
from
a4ea4e6 to
fea856b
Compare
bernt-matthias
force-pushed
the
del_job_conf.xml.sample_advanced
branch
from
fea856b to
a888ccb
Compare
martenson
added
the
kind/refactoring
|
This is a great idea, I've been bitten by the docs being different between xml and yaml before. fwiw the CI fails seem relevant |
bernt-matthias
force-pushed
the
del_job_conf.xml.sample_advanced
branch
2 times, most recently
from
303e926 to
e00c6d7
Compare
bernt-matthias
force-pushed
the
del_job_conf.xml.sample_advanced
branch
from
e00c6d7 to
2a0e2a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample config is one of the main sources of docs for job configuration. Unfortunately docs are sometimes still added to the good old xml sample config (eg #18628).
Here I suggest to (re) move the xml sample config (only keeping it for testing).
I manually went through the yml and xml version of the files and tried to sync them.
Alternatively we can strip the XML of all comments and add a reference to the yaml file.
How to test the changes?
(Select all options that apply)
License