[WIP] Use GModal in Selection Dialog #20375
Draft
+52
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedhamidawan
added
kind/enhancement
area/UI-UX
kind/refactoring
ahmedhamidawan
changed the title
Styling needs improvement; the filter field scrolls with the table. I moved it from the header because it doesn't look nice when the component has a `props.title`.
ahmedhamidawan
force-pushed
the
use_g_modal_in_selection_dialog
branch
from
b7fde47 to
f13b951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Styling needs improvement; the filter field scrolls with the table. I moved it from the header because it doesn't look nice when the component has a
props.title.How to test the changes?
(Select all options that apply)
License