Skip to content

Conversation

bernt-matthias
Copy link
Contributor

test referred to a non-existent job-config file and jobconf referred to wrong function

xref #7854

Is there a way to make our testing framework more strict, i.e. just fail if loading of a config file fails. Currently we just have

galaxy.jobs WARNING 2025-03-06 12:33:05,981 [pN:main,p:8946,tN:MainThread] Job configuration "/home/berntm/projects/galaxyproject/galaxy/test/integration/resubmission_default_job_conf.xml" does not exist, using default job configuration

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

test referred to a non-existent job-config file
and jobconf referred to wrong function

xref galaxyproject#7854
@nsoranzo
Copy link
Member

nsoranzo commented Mar 6, 2025

Is there a way to make our testing framework more strict, i.e. just fail if loading of a config file fails. Currently we just have

galaxy.jobs WARNING 2025-03-06 12:33:05,981 [pN:main,p:8946,tN:MainThread] Job configuration "/home/berntm/projects/galaxyproject/galaxy/test/integration/resubmission_default_job_conf.xml" does not exist, using default job configuration

Drop these lines and see what happens?

@bernt-matthias bernt-matthias force-pushed the fix-resubmission-integration-test branch 2 times, most recently from e1a70a1 to f3a7ccc Compare March 6, 2025 14:22
@mvdbeek mvdbeek removed this from the 25.0 milestone May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants