Skip to content

Conversation

@patmagee
Copy link
Contributor

@patmagee patmagee commented Apr 18, 2023

Motivation

This release focuses on two main themes: Observability and Scalability.

Observability: As more people have adopted WES it has become clear that the current API does not provide enough information for end users. The RunStatus and Log models have limited required keys and making actionable decisions on the information that is available is difficult without performing additional requests.

Scalability: As more implementors are looking to "productize" WES, the topic of scalability has continuously come up. Specific features of WES (such as embedded task logs) make implementing WES API a challenge, and can cause the service to break (Ie too many task cause a service to consume too much memory).

What's Changed

Additional Improvements

  • Removed travis CI integration and added GitHub actions for publishing docs and linting openapi.yaml
  • Removed example python client code in b5f782e
  • Removed duplicated swagger specification in favour of consolidated OpenAPI3 specification

jaeddy and others added 30 commits June 22, 2020 15:56
explode out openapi spec to use multifile organization
Remove swagger Definition and Reference Python Code
Switch to github actions and add Open API lining and validation
Updated requested permissions for doc build
Changed actions to use pull_request_target
* Add in PREEMPTED.

* Resolve reorganization of yaml's into 1 single yaml.
…a request. Closes #181 (#182)

* Add in support for workflow enginer and version when submitting a request.

* Expand out Workflow Engine version to by array of strings.

* Update RunRequest.yaml

* Add in workflow_engine and version to the run spec.

* Fix typo

* Fix for consitency

* Add more clarity about engine and version

* Update description

* Address changes requested.

* Fix indentation.

* Resolve reorganization of yaml's into 1 single yaml.

* Remove preempted with accidental merge.

* Add required parameter for:
- workflow_type
- workflow_type_version
- workflow_url
* Merge changes from develop

* Removed invalid attribute from openapi definition and aded nullable field instead

* Added explicit deprecation warning on the task_log property
…205)

* Added TaskLog model and created endpoint for retrieving a single task by id

* Added system_logs and tes_uri properties to TaskLog object

* Fixed spec tag metadata to include TaskLog and TaskListResponse

* Updated TaskLog to extend Log, and allow an array of TaskLog items to be returned in the task_log field

* Fixed casing on models and error response description
@uniqueg
Copy link
Contributor

uniqueg commented Apr 18, 2023

Thanks a lot for this @patmagee!

I would just like to point out that there is neither a tag nor a release for 1.1.0 yet. So I guess we should either find the commit that was supposed to represent 1.1.0, tag that and create a release (as discussed here for 1.0.1: #191) or set the upcoming release associated with this PR to 1.1.0.

Of note: The workflow version indicated in branch develop is still, as of today (last update 2 hours ago), 1.0.1. See

.

As @vinjana pointed out here, the 1.0.1 release didn't follow SemVer (should have been 1.1.0 instead), but that is now history. But I think one thing we could do is bump the current version in develop to 1.1.0, tag and release. Then rebase this PR against that for a 1.2.0 release.

@vsmalladi
Copy link
Contributor

@uniqueg and @patmagee I think the intention was 1.0.1 was supposed to be 1.1.0. Thus my recommendation would be to add another taged release at the same commit as 1.0.1 and mention in the notes that this was supposed to be SemVer 1.1.0, but don't change the version in the repo. In tag release notes 1.2.0 explain the issue and why we moved to SemVer 1.2.0

@patmagee patmagee closed this Jun 8, 2023
@patmagee patmagee deleted the release-1.2.0 branch June 8, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants