-
Notifications
You must be signed in to change notification settings - Fork 37
RC-v1.2.0 #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC-v1.2.0 #208
Conversation
explode out openapi spec to use multifile organization
Remove swagger Definition and Reference Python Code
Switch to github actions and add Open API lining and validation
Updated requested permissions for doc build
Fix/openapi definition
merge master back into develop
Changed actions to use pull_request_target
* Add in PREEMPTED. * Resolve reorganization of yaml's into 1 single yaml.
…a request. Closes #181 (#182) * Add in support for workflow enginer and version when submitting a request. * Expand out Workflow Engine version to by array of strings. * Update RunRequest.yaml * Add in workflow_engine and version to the run spec. * Fix typo * Fix for consitency * Add more clarity about engine and version * Update description * Address changes requested. * Fix indentation. * Resolve reorganization of yaml's into 1 single yaml. * Remove preempted with accidental merge. * Add required parameter for: - workflow_type - workflow_type_version - workflow_url
* Merge changes from develop * Removed invalid attribute from openapi definition and aded nullable field instead * Added explicit deprecation warning on the task_log property
…205) * Added TaskLog model and created endpoint for retrieving a single task by id * Added system_logs and tes_uri properties to TaskLog object * Fixed spec tag metadata to include TaskLog and TaskListResponse * Updated TaskLog to extend Log, and allow an array of TaskLog items to be returned in the task_log field * Fixed casing on models and error response description
|
Thanks a lot for this @patmagee! I would just like to point out that there is neither a tag nor a release for Of note: The workflow version indicated in branch workflow-execution-service-schemas/openapi/workflow_execution_service.openapi.yaml Line 5 in ec84aa4
As @vinjana pointed out here, the |
|
@uniqueg and @patmagee I think the intention was |
Motivation
This release focuses on two main themes: Observability and Scalability.
Observability: As more people have adopted WES it has become clear that the current API does not provide enough information for end users. The
RunStatusandLogmodels have limited required keys and making actionable decisions on the information that is available is difficult without performing additional requests.Scalability: As more implementors are looking to "productize" WES, the topic of scalability has continuously come up. Specific features of WES (such as embedded task logs) make implementing WES API a challenge, and can cause the service to break (Ie too many task cause a service to consume too much memory).
What's Changed
PREEMPTEDby @vsmalladi in feat: add run state PREEMPTED #188RunListResponsemodel will only returnRunSummarystarting in2.0.0task_logsproperty in theRunLogmodel has been deprecated in favour of the task list endpoint, and will be removed in2.0.0Additional Improvements