-
Notifications
You must be signed in to change notification settings - Fork 54
Optional DRS upload and delete extensions #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
grsr
wants to merge
15
commits into
develop
Choose a base branch
from
feature/issue-416-drs-upload
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I have made a flurry of updates including some changes to minor details of the spec, and added more docs on implementation considerations, I think this proposal is now fairly stable and I'd very much welcome any comments or feedback. I will present this proposal in the Cloud WS call on November 10th. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRS Upload and Delete Extensions
This PR adds optional upload, delete and access method update endpoints to the DRS specification, enabling complete DRS object lifecycle management. Existing DRS servers remain fully compliant without implementing these extensions.
New Endpoints
Upload
POST /upload-request- Negotiate upload methods and credentials for file uploadsPOST /objects/register- Register uploaded files or existing data as DRS objectsDelete
POST /objects/{object_id}/delete- Delete single DRS object with optional storage data removalPOST /objects/delete- Bulk delete DRS objects with optional storage data removalUpdate Access Methods
POST /objects/{object_id}/access-methods- Update access methods for a single DRS objectPOST /objects/access-methods- Update access methods for multiple DRS objectsService Discovery
New service-info flags for granular capability advertisement:
uploadRequestSupported/objectRegistrationSupporteddeleteSupported/deleteStorageDataSupportedaccessMethodUpdateSupported/validateAccessMethodUpdatemaxUploadRequestLength,maxRegisterRequestLength,maxBulkDeleteLength,maxBulkAccessMethodUpdateLengthThis approach supports GA4GH Passports, Bearer tokens, and API keys for authentication. We use POST methods rather than DELETE to allow passports to be used in deletion requests.
The details and motivation for the proposal are included in the documentation for the new endpoints, which are rendered here: https://ga4gh.github.io/data-repository-service-schemas/preview/feature/issue-416-drs-upload/docs/
NB: The link to the rendered documentation is not updating and shows stale content, please refer to the files in the most recent commit. The main docs are linked below:
The corresponding issue is #417 but please also refer to the discussion for issue #416, which this PR should be considered a continuation of.