Engagement PR: splitting & refactoring into a RequestProfile caller #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the previous nested structure into separate V2 and VQS definitions, both accessible through a single `RequestProfile` caller. * `RequestProfile` provides one profile from either `RequestProfileV2` or `RequestProfileVQS`; Pascal case, singular since providing a single `oneOf` definition themselves * `RequestProfileV2` and `RequestProfileVQS` provide a sigle profile from the definitions of the V2 or VQS profiles defined within. This is mostly to allow a better disentanglement of versions; other ways can be implemented (e.g. having the definitions in separate component files ...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Engagement PR"
This PR is used to move to a standard community develop & comment process after having established some code structure for the request profiles proposal.
Note to reviewers: This is a "dynamic engagement" call, to gather suggestions for action items; merging might happen at any time dependent on feedback but with continuing work then on
mainor new topic branches.The PR itself changes the previous nested structure into separate V2 and VQS definitions, both accessible through a single
RequestProfilecaller.RequestProfileprovides one profile from eitherRequestProfileV2orRequestProfileVQS; Pascal case, singular since providing a singleoneOfdefinition themselvesRequestProfileV2andRequestProfileVQSprovide a sigle profile from the definitions of the V2 or VQS profiles defined within.This is mostly to allow a better disentanglement of versions; other ways can be implemented (e.g. having the definitions in separate component files ...).