refactor xkcd layout #20
Conversation
|
This is a good idea, thanks. |
|
I went with picking a decent size default xkcd window size and recenter. I tried several ways to resize the image container, but that would not cause the window itself to resize. I also considered resizing the window based on the the image size, but that seemed awkward and would probably introduce a number of edge cases. |
andydotxyz
left a comment
andydotxyz
left a comment
There was a problem hiding this comment.
I think it went a little too far the other way ;)
Good catch on the labels though
| form, buttons, x.image)) | ||
| layout.NewBorderLayout(controlsContainer, nil, nil, nil), | ||
| controlsContainer, imageContainer)) | ||
| w.Resize(fyne.NewSize(1000, 800)) // will limit to screensize |
There was a problem hiding this comment.
Are you sure this is a sensible start size? it seems very large?
I agree it will (depending on OS) likely limit to screen size, but it doesn't seem like the kind of window that wants to be so big.
Also I don't think we should be requesting center on screen without good reason.
|
Do you want to pick this up with a smaller window size? |
3 participants
refactor xkcd layout so buttons are always reachable and image doesn't run off screen.
If the image is large, I found that image forces the bottom buttons to be off screen and not reachable. The problem is worse on a Notebook computer.