Conversation
Removed the DataCacheSnapshot class, which provided a UI-friendly snapshot of DataCache for synchronous reads on the main actor.
The previous tests relied on bufferingNewest(1) behavior to imply that unwanted emissions didnt happen — but this silently swallows the evidence either way, making the tests pass even if the equality guards were removed. Replace with confirmation(expectedCount: 0) to explicitly assert that no emission occurs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move repeated confirmation(expectedCount: 0) pattern into a reusable assertNoEmission(on:during:) helper. Place it at the bottom of the file under a MARK section. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ssestak
left a comment
ssestak
left a comment
There was a problem hiding this comment.
The only thing I found out is that the tests is written in the way that name of the test suggests something but in my opinion it is not properly executed and it can produce some false positive outcomes. That's why I opened an PR where I tried to improve them please view the #53
…ssertions Fix false-positive DataCache emission tests
|
@ssestak @samoilyk guys what was the motivation behind creating a DataModel as an |
Here's follow up with MainActor DataCache #54. Check it out please. |
4 participants
Minimum SDK iOS 17, Swift tools 6.1
Replaced Combine with Async&Await
Replaced ObservableObject with @observable
Replaced @StateObject with @State
All models Sendable
Helpers updated - Alert, Camera & ImagePicker
Templates updated
Added tests (AI generated)
Code cleanup
Migration guide https://github.com/futuredapp/FTClaudeMarketplace/blob/main/ios/futuredkit-plugin/commands/migrate-futuredkit-swift6.md