Create no-errors-root-canonical.html - #29
Merged
Merged
Conversation
Reproduces the false positive from fulldecent#28 where nice-checkers/canonical-link incorrectly flags root canonical URLs with multi-character TLDs (e.g. https://example.com with no trailing slash) as having a file extension, because the check tests the full href instead of url.pathname.
Owner
|
Thank you for sharing. Can you please address the style lint issue in the CI? |
Contributor
Author
|
Great, updated with prettier. |
Owner
|
Cool, thank you, merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduces the false positive from #28 where nice-checkers/canonical-link incorrectly flags root canonical URLs with multi-character TLDs (e.g. https://example.com with no trailing slash) as having a file extension, because the check tests the full href instead of url.pathname.